Sidebar #53
Merged
Sidebar #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All very hacky, needing to be torn down and replaced Conflicts: drupal_annotation/annotation.store.inc drupal_annotator/annotator_view/categories.js drupal_annotator/annotator_view/css/style.css drupal_annotator/annotator_view/img/Compartido.png drupal_annotator/annotator_view/img/edit-icon.png drupal_annotator/annotator_view/img/icono_eliminar.png drupal_annotator/annotator_view/img/papelera_over.png drupal_annotator/annotator_view/img/shared-icon.png drupal_annotator/annotator_view/lib/jquery-i18n-master/.gitignore drupal_annotator/annotator_view/lib/jquery-i18n-master/Gruntfile.js drupal_annotator/annotator_view/lib/jquery-i18n-master/LICENSE drupal_annotator/annotator_view/lib/jquery-i18n-master/README.md drupal_annotator/annotator_view/lib/jquery-i18n-master/SpecRunner.html drupal_annotator/annotator_view/lib/jquery-i18n-master/bower.json drupal_annotator/annotator_view/lib/jquery-i18n-master/examples/index.html drupal_annotator/annotator_view/lib/jquery-i18n-master/examples/jquery-1.4.2.js drupal_annotator/annotator_view/lib/jquery-i18n-master/jquery.i18n.js drupal_annotator/annotator_view/lib/jquery-i18n-master/jquery.i18n.min.js drupal_annotator/annotator_view/lib/jquery-i18n-master/lib/jasmine-1.2.0/MIT.LICENSE drupal_annotator/annotator_view/lib/jquery-i18n-master/lib/jasmine-1.2.0/jasmine-html.js drupal_annotator/annotator_view/lib/jquery-i18n-master/lib/jasmine-1.2.0/jasmine.css drupal_annotator/annotator_view/lib/jquery-i18n-master/lib/jasmine-1.2.0/jasmine.js drupal_annotator/annotator_view/lib/jquery-i18n-master/package.json drupal_annotator/annotator_view/lib/jquery-i18n-master/specs/jquery.i18n.spec.js drupal_annotator/annotator_view/lib/jquery-i18n-master/src/jquery.i18n.js drupal_annotator/annotator_view/lib/jquery.dateFormat.js drupal_annotator/annotator_view/lib/jquery.slimscroll.js drupal_annotator/annotator_view/view_annotator.js
Just keep the code for adding in a sidebar
|
Why was this never merged? May I ask what was the approach to display the sidebars? I am working on a new theming framework/workflow for edgeryders.eu and would appreciate to collect any thoughts already made here. I'm currently strongly inclined to use CTools collapsible divs for this. |
|
@tanius OK to merge this? One more thing out of the way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.