Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: do not use deprecated and removed 'Feature' feature #39

Merged
merged 1 commit into from Mar 9, 2021

Conversation

eli-schwartz
Copy link
Contributor

Emulate it using environment variables instead. $GENSHI_BUILD_SPEEDUP is checked for existence and parsed as an integer boolean, with invalid values defaulting (loudly) to 0.

Fixes #36

@eli-schwartz
Copy link
Contributor Author

The 0.7.5 release notes are incorrect, "C speedup module now available for Python >= 3.3" can't even be imported. :D I tried updating to 0.7.5 and kept getting lint warnings for missing ELF files which was slightly disappointing.

Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sorting this out!

I made two minor suggestions, but otherwise LGTM.

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
Emulate it using environment variables instead. $GENSHI_BUILD_SPEEDUP is
checked for existence and parsed as an integer boolean, with invalid
values defaulting (loudly) to 0.

Fixes edgewall#36
@hodgestar hodgestar merged commit ecec782 into edgewall:master Mar 9, 2021
@hodgestar
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite speedups extension compilation in setup.py
2 participants