Skip to content

Commit

Permalink
1.3.4dev: place group heading in td element of TracQuery tabular results
Browse files Browse the repository at this point in the history
The nu validator reported the previous `<th> <h2>...</h2> </th>`
embedding as invalid:
{{{
The element h2 must not appear as a descendant of the th element.
}}}

Refs #12752.


git-svn-id: http://trac.edgewall.org/intertrac/log:/trunk@16880 af82e41b-90c4-0310-8c96-b1721e28e2e2
  • Loading branch information
cboos committed Jan 8, 2019
1 parent 95adf67 commit c0d4282
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions trac/htdocs/css/report.css
Expand Up @@ -84,7 +84,7 @@ h1 .numrows, h2 .numrows {
h2.report-result {
background: #f7f7f7;
border-bottom: 1px solid #d7d7d7;
margin: 2em 0 0;
margin: 2em 0 .6em 0;
padding: .2em .4em;
box-shadow: 1px 1px .5em 0 #ccc;
border-radius: .1em
Expand Down Expand Up @@ -221,7 +221,7 @@ h2.report-result {
/* Query results table */

table.tickets caption.trac-group {
padding: .1em .5em 1em .5em;
padding: .1em .5em; /* same as .tickets tbody td */
border: 1px dotted #ddd;
text-align: left;
}
Expand Down
4 changes: 2 additions & 2 deletions trac/ticket/templates/query_results.html
Expand Up @@ -90,9 +90,9 @@ <h2 class="report-result" >
<tbody class="trac-query-heading">
# if groupname is not none:
<tr class="trac-group">
<th class="trac-colspan" colspan="${num_cols}">
<td class="trac-colspan" colspan="${num_cols}">
${group_heading(groupname, results)}
</th>
</td>
</tr>
# endif
${column_headers()}
Expand Down

0 comments on commit c0d4282

Please sign in to comment.