Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add metric for Store And Forward queue size #1538

Merged
merged 2 commits into from
Jan 17, 2024
Merged

feat: Add metric for Store And Forward queue size #1538

merged 2 commits into from
Jan 17, 2024

Conversation

lenny-goodell
Copy link
Member

closes #1138

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

feat: Add metric for Store And Forward queue size
e6c8086 
closes edgexfoundry#1138

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
jim-wang-intel
jim-wang-intel previously approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fix: Adjust failing unit test
11d2ee9 
Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (15d59e2) 66.27% compared to head (11d2ee9) 66.19%.

Files Patch % Lines
internal/runtime/storeforward.go 50.00% 4 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1538      +/-   ##
==========================================
- Coverage   66.27%   66.19%   -0.09%     
==========================================
  Files          36       36              
  Lines        3238     3248      +10     
==========================================
+ Hits         2146     2150       +4     
- Misses        951      955       +4     
- Partials      141      143       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenny-goodell lenny-goodell merged commit 763fccf into edgexfoundry:main Jan 17, 2024
3 checks passed
@lenny-goodell lenny-goodell deleted the sf-metric branch January 17, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-wang-intel jim-wang-intel jim-wang-intel approved these changes

@ejlee3 ejlee3 Awaiting requested review from ejlee3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SDK] Additional metrics
3 participants
@lenny-goodell @codecov-commenter @jim-wang-intel