add support-logging test script #35
Conversation
Signed-off-by: Bruce <weichou1229@gmail.com>
|
@tsconn23 please help check this PR . |
|
recheck |
1 similar comment
|
recheck |
Signed-off-by: Bruce <weichou1229@gmail.com>
# Conflicts: # bin/arm64_env.sh # bin/env.sh # docker-compose.yml
Signed-off-by: Bruce <weichou1229@gmail.com>
| @@ -0,0 +1,192 @@ | |||
| var dbName = 'logging'; | |||
There was a problem hiding this comment.
Please make this a JSON file. All of the other DataDumps files are JSON files, so this one should be as well. In addition, the other DataDumps directories have a populate.sh script that is used for population. Please use the same methodology in this case.
There was a problem hiding this comment.
In my opinion, JSON file is not maintainable and hard to check syntax error ,and I also use mongo js lib in support-notification test .
There was a problem hiding this comment.
I had add populate.sh and environment file , please check .
There was a problem hiding this comment.
@weichou1229 Well then you now have a situation where the mechanism to populate data for this one group of tests is different from the others. It needs to be uniform. If you're going to change it for all of them, do that as a separate PR. @cloudxxx8
And I just noticed that in the PR for the new export-client tests, you used a JSON file. So please make this consistent.
https://github.com/edgexfoundry/blackbox-testing/pull/39/files#diff-f58cab9c339000f0f7727132fd442c65
There was a problem hiding this comment.
ok , I will change all my PR to JSON file
| @@ -0,0 +1,42 @@ | |||
| { | |||
There was a problem hiding this comment.
Can we both name this file and set the "name" property so that the default name is appropriate when imported into Postman? "support-logging.json" perhaps?
| @@ -0,0 +1,42 @@ | |||
| { | |||
There was a problem hiding this comment.
Can we both name this file and set the "name" property so that the default name is appropriate when imported into Postman? "support-logging-docker.json" perhaps?
Signed-off-by: Bruce <weichou1229@gmail.com>
…json and Signed-off-by: Bruce <weichou1229@gmail.com>
…port-logging-docker.postman_environment.json Signed-off-by: Bruce <weichou1229@gmail.com>
| @@ -0,0 +1,3 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
@weichou1229 Thanks for adding this but see my other comments regarding how it's a different methodology from the existing test data population @cloudxxx8
There was a problem hiding this comment.
@tsconn23 I had changed dump file to json format , please check .
Signed-off-by: Bruce <weichou1229@gmail.com>
Signed-off-by: Bruce <weichou1229@gmail.com>
Signed-off-by: Bruce <weichou1229@gmail.com>
Signed-off-by: Bruce <weichou1229@gmail.com>
…json and Signed-off-by: Bruce <weichou1229@gmail.com>
…port-logging-docker.postman_environment.json Signed-off-by: Bruce <weichou1229@gmail.com>
Signed-off-by: Bruce <weichou1229@gmail.com>
Signed-off-by: Bruce <weichou1229@gmail.com>
Signed-off-by: Bruce <weichou1229@gmail.com>
…t max limit Signed-off-by: Bruce <weichou1229@gmail.com>
Signed-off-by: Trevor Conn <trevor_conn@dell.com>
Signed-off-by: Bruce weichou1229@gmail.com