Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the compose image size #129

Merged
merged 1 commit into from Jun 2, 2020
Merged

Reduce the compose image size #129

merged 1 commit into from Jun 2, 2020

Conversation

cherrycl
Copy link
Contributor

Signed-off-by: Cherry Wang cherry@iotechsys.com

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other... Please describe:

Issue Number: fix #128

Sandbox Testing

Test Links : https://jenkins.edgexfoundry.org/sandbox/view/All/job/edgex-compose-build/1/

Are there any specific instructions or things that should be known prior to reviewing?

Other information

Signed-off-by: Cherry Wang <cherry@iotechsys.com>
@cherrycl
Copy link
Contributor Author

cherrycl commented Apr 6, 2020

Could anyone help review this PR?

@cloudxxx8
Copy link
Member

@ernestojeda we made a change to improve the compose image. could you please help review it?
thanks.

Copy link
Contributor

@jamesrgregg jamesrgregg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8
Copy link
Member

@ernestojeda could you please help take a look? thanks

@lranjbar lranjbar added this to QA/Code Review in DevOps WG via automation May 1, 2020
@jamesrgregg jamesrgregg requested a review from lranjbar May 6, 2020 15:24
Copy link
Contributor

@ernestojeda ernestojeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! 👍

@cloudxxx8
Copy link
Member

@ernestojeda and @jamesrgregg , since we have released Geneva, could you please help merge this PR? It could improve the performance of blackbox tests.
Thanks.

@cloudxxx8
Copy link
Member

@lranjbar ,@ernestojeda and @jamesrgregg could you please help merge this PR? thanks.

@lranjbar lranjbar merged commit 3713164 into edgexfoundry:edgex-compose Jun 2, 2020
DevOps WG automation moved this from QA/Code Review to Done Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
DevOps WG
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants