Issue 308 #321
Merged
Issue 308 #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: don't attempt to transform floats that are Inf or NaNs fix: check type for strings in toml config Signed-off-by: Iain Anderson <iain@iotechsys.com>
Signed-off-by: Iain Anderson <iain@iotechsys.com>
Signed-off-by: Iain Anderson <iain@iotechsys.com>
SteveOss
reviewed
Feb 12, 2021
There was a problem hiding this comment.
@iain-anderson In edgex_propertytype_tostring have replaced strcasecmp with strcmp, does this mean type names are now case sensitive ?
Yes but they should be normalized during validation in core-metadata (code here) |
|
@iain-anderson And this is the only path to this function ? |
|
@SteveOss it will only be used when receiving a device profile update notification from metadata, or when requesting a device profile from metadata (when a device is instantiated for which we don't yet have the profile definition) |
This was referenced Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-c/blob/master/.github/CONTRIBUTING.md
What is the current behavior?
Issue Number: #303 #308
What is the new behavior?
Checks added for CheckInterval, ProfilesDir being unset
Changed type names
Added MaxRequestSize configuration option and enforced in http processing
Does this PR introduce a breaking change?
Type names in device profiles are now case-sensitive (in practice this
is a breaking change in core-metadata where they will be validatedshould not be an issue as they are normalised in core-metadata)New Imports
Specific Instructions
Other information