Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement binary encoding of Events & Readings #23

Closed
tonyespy opened this issue Aug 13, 2018 · 3 comments
Closed

Implement binary encoding of Events & Readings #23

tonyespy opened this issue Aug 13, 2018 · 3 comments
Assignees
@tobiasmo1
Labels
enhancement New feature or request
Projects
Strike Team: EdgeX Binary/CBOR

Comments

@tonyespy
Copy link
Member

Implement binary encoding (using CBOR) of events & readings.

This first assumes that a new bytes field (vs. the result field which is a string) has been added to the Reading struct, so the CBOR can encode the byes properly.

Estimated effort: 5-7d
@tonyespy tonyespy added the enhancement New feature or request label Aug 13, 2018
@cloudxxx8 cloudxxx8 mentioned this issue Oct 16, 2018
Merged
@tobiasmo1 tobiasmo1 self-assigned this Apr 2, 2019
@tobiasmo1 tobiasmo1 mentioned this issue Apr 2, 2019
Closed
@tsconn23
Copy link
Member

Binary Value []byte has been added to the Reading

https://github.com/edgexfoundry/go-mod-core-contracts/blob/24a36f294d12b108636e27c6184f22ea24766959/models/reading.go#L38

The EventClient should both facilitate the marshaling of the event and addition of the event as a byte array.

@tobiasmo1
Copy link
Contributor

This is resolved in PR#293

tobiasmo1 added a commit that referenced this issue May 24, 2019
@tobiasmo1
Send CBOR/JSON events using contract EventClient (#293)
4cdf064 
Resolves Issue #23 

* Use common EventClient.MarshalEvent and EventClient.AddBytes to send CBOR/JSON.
* Clean up DS event model and logging.
* Note that DS event model is now only used for identifying Content-Type; we should refactor to remove in separate commit.
* Updated make test build directive to add vet, gofmt and to output code coverage file
@cloudxxx8
Copy link
Member

As @tobiasmo1 mentioned, this is resolved in PR#293

@lranjbar lranjbar moved this from In progress to Done in Strike Team: EdgeX Binary/CBOR Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobiasmo1 tobiasmo1

Labels
enhancement New feature or request
Projects
No open projects
Strike Team: EdgeX Binary/CBOR
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tsconn23 @tonyespy @cloudxxx8 @tobiasmo1