-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: replace REST device validation callback with MessageBus #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@hahattan , this PR #1316 needs to be merged first so yours doesn't have all the changes that it takes care of. |
d6e18c1
to
5b97474
Compare
lenny-goodell
requested changes
Feb 15, 2023
5b97474
to
4beef8a
Compare
Merged
5 tasks
4beef8a
to
0d14b0d
Compare
lenny-goodell
previously approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BREAKING CHANGE: remove /validate/device REST endpoint closes edgexfoundry#1260 Signed-off-by: Chris Hung <chris@iotechsys.com>
0d14b0d
to
6834b70
Compare
lenny-goodell
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
weichou1229
pushed a commit
to weichou1229/device-sdk-go
that referenced
this pull request
Mar 20, 2023
…foundry#1325) BREAKING CHANGE: remove /validate/device REST endpoint closes edgexfoundry#1260 Signed-off-by: Chris Hung <chris@iotechsys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: remove /validate/device REST endpoint
closes #1260
Signed-off-by: Chris Hung chris@iotechsys.com
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
metadata
from feat(metadata)!: replace REST device validation callback with MessageBus edgex-go#4366 branchdevice-simple
from this branch withDEBUG
logNew Dependency Instructions (If applicable)