This repository has been archived by the owner on May 26, 2023. It is now read-only.
fix: fix missing configuration file in distribution archives #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## hanoi #371 +/- ##
===========================================
+ Coverage 14.51% 24.71% +10.20%
===========================================
Files 3 3
Lines 62 89 +27
===========================================
+ Hits 9 22 +13
- Misses 53 62 +9
- Partials 0 5 +5
Continue to review full report at Codecov.
|
difince
force-pushed
the
hanoi
branch
2 times, most recently
from
4c02a9a
to
626b660
Compare
- configuration.toml file under project's /res dir is renamed to ./sample-configuration.toml file - the configuration.toml file under $home/.edgex-cli directory is created on the fly by the code using as a template ./sample-configuration.toml file if it does not exists - one of the unit test is removed as not relevant anymore - All executables within distribution archives have the same name of: edgex-cli - Cleaning up Makefile of references to res/configuration.toml (build, install and clean targets) - updated snap to levarage sample-configuration.toml file Signed-off-by: Diana Atanasova <dianaa@vmware.com>
Do not create /res directory in GOBIN. This is a place for executables only. add "@" when echo, thus removing double printing the message Signed-off-by: Diana Atanasova <dianaa@vmware.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Diana Atanasova dianaa@vmware.com
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-cli/blob/master/.github/Contributing.md.
What is the current behavior?
Issue Number:
What is the new behavior?
./sample-configuration.toml file
created on the fly by the code using as a template ./sample-configuration.toml file
if it does not exists
(build, install and clean targets)
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information