Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove unneeded edgex-kong network alias #428

Merged
merged 1 commit into from
Jan 10, 2024
Merged

refactor: Remove unneeded edgex-kong network alias #428

merged 1 commit into from
Jan 10, 2024

Conversation

lenny-goodell
Copy link
Member

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-compose/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) *N/A

Testing Instructions

refactor: Remove unneeded edgex-kong network alias
82806d4 
Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@lenny-goodell lenny-goodell added the tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds label Jan 10, 2024
@lenny-goodell lenny-goodell added this to the Odessa milestone Jan 10, 2024
ejlee3
ejlee3 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@ejlee3 ejlee3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 5568001 into edgexfoundry:main Jan 10, 2024
3 checks passed
@lenny-goodell lenny-goodell deleted the kong-alias branch January 10, 2024 18:16
@cloudxxx8 cloudxxx8 mentioned this pull request Mar 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-wang-intel jim-wang-intel jim-wang-intel approved these changes

@ejlee3 ejlee3 ejlee3 approved these changes

Assignees
No one assigned
Labels
tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds
Projects
Core/QA WG
Status: Odessa Done
Milestone
Odessa
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lenny-goodell @jim-wang-intel @ejlee3