feat: Create System Events ADR #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
requested review from
tonyespy,
jpwhitemn,
farshidtz,
cloudxxx8,
bnevis-i,
iain-anderson and
JamesKButcher
lenny-goodell
force-pushed
the
system-events-adr
branch
from
310622c
to
b523d2f
Compare
|
recheck |
cloudxxx8
reviewed
Jul 13, 2022
added 3 commits
July 14, 2022 08:44
closes edgexfoundry#581 Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
lenny-goodell
force-pushed
the
system-events-adr
branch
from
2771a42
to
b4cf6e7
Compare
bnevis-i
previously approved these changes
Jul 19, 2022
jpwhitemn
previously approved these changes
Jul 20, 2022
iain-anderson
previously approved these changes
Jul 20, 2022
farshidtz
requested changes
Jul 20, 2022
5 tasks
Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
5 tasks
- Changed Publish Topic Prifix to be in configuration - Clarified standard topic level vs addition levels for specific use cases - Fixed typos. Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
lenny-goodell
dismissed stale reviews from iain-anderson, JamesKButcher, cloudxxx8, jpwhitemn, and bnevis-i
via
db495c3
|
|
||
| `edgex/system-event/{source}/{type}/{action}/{owner}/{profile}` | ||
| `edgex/system-event/{source}/{type}/{action}` |
There was a problem hiding this comment.
Would it more properly be {PublishTopicPrefix}/{source}/{type}/{action} ?
Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
bnevis-i
approved these changes
Jul 25, 2022
edgex-jenkins
added a commit
that referenced
this pull request
Jul 26, 2022
Signed-off-by: edgex-jenkins <collab-it+edgex@linuxfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes edgexfoundry/edgex-go#581
Signed-off-by: Leonard Goodell leonard.goodell@intel.com
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-docs/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements: