Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(snap): Upgrade kong, redis, consul, vault #4210

Conversation

MonicaisHer
Copy link
Contributor

@MonicaisHer MonicaisHer commented Oct 24, 2022

Signed-off-by: Mengyi Wang mengyi.wang@canonical.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@farshidtz
Copy link
Member

farshidtz commented Oct 24, 2022

Using Redis 7.0.5 and 7.0.0 both result in the following error:

Oct 24 14:47:13 fv-az96-423 edgexfoundry.redis[4141]: *** FATAL CONFIG FILE ERROR (Redis 7.0.5) ***

This needs further investigation; maybe there are new config files that the snap isn't installing.

For now, we can proceed with v6.2.7 as it has the latest CVE fixes that aren't affecting v7 features.

@farshidtz farshidtz marked this pull request as ready for review October 24, 2022 16:33
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the refresh/upgrade tests on a build from this PR and the tests passed.

Command to run all tests from here, incl. the refresh tests:

PLATFORM_CHANNEL=latest/edge/pr-4210 go test -v --timeout 20m ./test/suites/edgexfoundry

@codecov-commenter
Copy link

Codecov Report

Merging #4210 (865dd42) into main (2325198) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4210   +/-   ##
=======================================
  Coverage   43.28%   43.28%           
=======================================
  Files         125      125           
  Lines       11106    11106           
=======================================
  Hits         4807     4807           
  Misses       5887     5887           
  Partials      412      412           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants