Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add convenient alias for each services build and docker target #4123

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

lenny-goodell
Copy link
Member

Signed-off-by: Leonard Goodell leonard.goodell@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

run make with each of the alias targets
Verify the proper target is executed.

New Dependency Instructions (If applicable)

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ernestojeda ernestojeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice aliases

@lenny-goodell
Copy link
Member Author

@farshidtz , snap test is failing on this PR that simply added addition make targets. It is also failing on this PR: #4119

@codecov-commenter
Copy link

Codecov Report

Merging #4123 (bcf2657) into main (e3ca38a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4123   +/-   ##
=======================================
  Coverage   43.66%   43.66%           
=======================================
  Files         120      120           
  Lines       10617    10617           
=======================================
  Hits         4636     4636           
  Misses       5594     5594           
  Partials      387      387           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@farshidtz
Copy link
Member

@farshidtz , snap test is failing on this PR that simply added addition make targets.

Github sometimes becomes too slow and the operations happen at a different order than originally expected. Will improve this. Moreover, rarely get strange errors like Web server failed: listen tcp 127.0.0.1:59880: bind: address already in use or other ports on the first run. This now passed after a few retries.

It is also failing on this PR: #4119

This was an actual implementation issue: #4119 (comment)

@lenny-goodell lenny-goodell merged commit 2391845 into edgexfoundry:main Aug 15, 2022
@lenny-goodell lenny-goodell deleted the make-alias branch August 15, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants