Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove device callback calls #4269

Merged
merged 1 commit into from
Jan 30, 2023
Merged

feat: remove device callback calls #4269

merged 1 commit into from
Jan 30, 2023

Conversation

chr1shung
Copy link
Member

device service is subscribing device system events and removing REST device callbacks in edgexfoundry/device-sdk-go#1259 The calls to the REST callback can be removed

closes #4235

Signed-off-by: Chris Hung chris@iotechsys.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

  1. Run metadata from this branch
  2. Run device-simple from device-sdk-go and verify device callbacks are working correctl.y

New Dependency Instructions (If applicable)

device service is subscribing device system events and removing REST
device callbacks in edgexfoundry/device-sdk-go#1259
The calls to the REST callback can be removed

closes #4235

Signed-off-by: Chris Hung <chris@iotechsys.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #4269 (36411bb) into main (1c8abb9) will increase coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4269      +/-   ##
==========================================
+ Coverage   42.93%   43.19%   +0.26%     
==========================================
  Files         119      119              
  Lines       10888    10822      -66     
==========================================
  Hits         4675     4675              
+ Misses       5801     5735      -66     
  Partials      412      412              
Impacted Files Coverage Δ
internal/core/metadata/application/device.go 15.60% <ø> (+0.53%) ⬆️
internal/core/metadata/application/notify.go 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chr1shung chr1shung marked this pull request as ready for review January 10, 2023 07:31
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Need to coordinate merging this with the SDK PR and Devices service PRs for TAF tests not to fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove device Add/Update/Delete callbacks
4 participants