Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(snap): Remove obsolete parts, upgrade Go, build nginx #4439

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

farshidtz
Copy link
Member

@farshidtz farshidtz commented Mar 14, 2023

  • Remove parts, layout, etc left-over from the removed kong and postgres apps ( feat(security)!: Implementation of JWT authentication ADR #4244)
  • Remove obsolete minimal build scripts
  • Remove unused drop daemon script
  • Remove obsolete passthroughs
  • Upgrade Go from 1.18 to 1.20
  • Add command to build nginx using the default process
  • Set the nginx source to release-1.23.3 with shallow clone
  • Bump epoch for the v2 to v3 edgex backward-incompatible upgrade

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

* Remove parts, layout, etc left-over from the removed kong and postgres apps
* Remove obsolete minimal build scripts
* Remove unused drop daemon script
* Remove passthroughs
* Upgrade Go from 1.18 to 1.20
* Add command to build nginx using the default process
* Bump epoch for the v2 to v3 edgex backward-incompatible upgrade

Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.3% 2.3% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #4439 (6c3c222) into main (b04a3d3) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #4439   +/-   ##
=======================================
  Coverage   41.73%   41.73%           
=======================================
  Files         106      106           
  Lines        9749     9749           
=======================================
  Hits         4069     4069           
  Misses       5333     5333           
  Partials      347      347           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@bnevis-i bnevis-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed build test. Looks OK.

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farshidtz farshidtz merged commit d51f32b into edgexfoundry:main Mar 15, 2023
@farshidtz farshidtz deleted the snap-refactor branch March 15, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants