Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Pull spire-server and spire-agent from prebuilt containers #4667

Merged
merged 1 commit into from
Aug 31, 2023
Merged

build: Pull spire-server and spire-agent from prebuilt containers #4667

merged 1 commit into from
Aug 31, 2023

Conversation

bnevis-i
Copy link
Collaborator

@bnevis-i bnevis-i commented Aug 30, 2023

SPIRE project is now publishing prebuilt containers for linux/amd64 and linux/arm64 on their github project that have statically-linked spire-server and spire-agent components. Rather than building locally, we can just reference the GHCR containers in a FROM line and directly pull in the binaries, without having to waste time building them.

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

"make docker" in this repo and "make run dev delayed-start ds-virtual" in edgex-compose/compose-builder and ensure all containers start properly. This should be tested both on Intel and ARM64 architectures to be valid.

New Dependency Instructions (If applicable)

@bnevis-i bnevis-i added this to QA/Code Review in Security WG Aug 30, 2023
@bnevis-i bnevis-i marked this pull request as ready for review August 30, 2023 22:30
jim-wang-intel
jim-wang-intel previously approved these changes Aug 30, 2023
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make docker and run dev works;
need to fix the hadolint dockerfile issues DL3026

Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
5.2% 5.2% Duplication

@bnevis-i
Copy link
Collaborator Author

make docker and run dev works; need to fix the hadolint dockerfile issues DL3026

Thanks, @jim-wang-intel . I added github container registry to the allow list.

@codecov-commenter
Copy link

Codecov Report

Merging #4667 (a8bd01a) into main (d700633) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #4667   +/-   ##
=======================================
  Coverage   41.88%   41.88%           
=======================================
  Files         105      105           
  Lines        9702     9702           
=======================================
  Hits         4064     4064           
  Misses       5296     5296           
  Partials      342      342           

@bnevis-i
Copy link
Collaborator Author

Validation completed on aarch64 vm.

@bnevis-i bnevis-i merged commit 7bfebe8 into edgexfoundry:main Aug 31, 2023
9 checks passed
Security WG automation moved this from QA/Code Review to Done Aug 31, 2023
@bnevis-i bnevis-i deleted the spire-optimization branch August 31, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Security WG
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants