Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow rules-engine service to read its token #4823

Merged
merged 3 commits into from
Jul 12, 2024
Merged

feat: allow rules-engine service to read its token #4823

merged 3 commits into from
Jul 12, 2024

Conversation

dovholuknf
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@dovholuknf
feat: allow rules-engine service to read its token
e1e4c21 
Signed-off-by: dovholuknf <46322585+dovholuknf@users.noreply.github.com>
@dovholuknf
fix: added env vars EDGEX_EKUIPER_USER_ID and EDGEX_EKUIPER_GROUP_ID …
6ecc0f5 
…to allow changing kuiper user id per PR feedback

Signed-off-by: dovholuknf <46322585+dovholuknf@users.noreply.github.com>
@dovholuknf
fix: convert casing to all upper
e2eb3b7 
Signed-off-by: dovholuknf <46322585+dovholuknf@users.noreply.github.com>
@dovholuknf dovholuknf force-pushed the allow-rules-engine-to-read-token branch from 59a54bf to e2eb3b7 Compare July 12, 2024 14:32
@dovholuknf
Copy link
Contributor Author

all set (also fixed the DCO)

cloudxxx8
cloudxxx8 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 5162257 into edgexfoundry:main Jul 12, 2024
5 checks passed
@cloudxxx8 cloudxxx8 mentioned this pull request Jul 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudxxx8 cloudxxx8 cloudxxx8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dovholuknf @cloudxxx8