-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1 ask: click on a place, get the water service provider #96
Comments
@Frijol in #97 I have four different ways of retrieving PSAs and PWSs for a place. This branch should not be merged, but I've drafted a pull request to have a conversation there. The idea is that we pick one and implement it in a separate development. Here's some description and my own thoughts on advantages/disadvantages. Curious what you think. First, keep in mind that these are just experiments in the "click on a place" part. There are no additional charts, pages (e.g. EJ, lead lines, etc.), and no default places. I assume those extras would be relatively easy to implement afterwards (though maybe not, especially the "default".) Some error handling is still necessary too. Please finally note the SBU server is currently unable to return relatively large chunks of data, so what we have here is a bit modified and hacked. It works temporarily for the purposes of demonstration. I'll email Gil about a server fix (this has happened before, should be a quick fix).
Ok, this took all day. I'm about out of time with this project. Unfortunately, I think we'll have to be quite strategic in what we are able to advance moving forward. I think this is the priority though. |
Just added:
|
P.S. As you navigate the experiments, keep in mind that some of them use some of the same |
This provides a solution to the zoom issues mentioned above! Just give a warning to the user that they should zoom in more.... (on the slippy and button selection options) 143d912 |
|
This is touched on in other issues & existing work, but I wanted to give it its own issue because it was Marianne's number one ask.
The text was updated successfully, but these errors were encountered: