Adds CoC badge per https://github.com/edgi-govdata-archiving/overview… #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, this is breaking CircleCI build and I don't understand why |
|
Looks like it failed on Zoom API credentials (have they been updated/this build would fail on any PR?) |
|
Oops, sorry I didn’t see this last week. @Frijol you made your PR from a fork instead of a branch on this repo, so as a security measure, Circle won’t give you access to secret env vars. |
|
@Mr0grog does that mean this is safe to merge despite the failed check? |
|
Sure! More generally, it means you’re always going to have this problem, which sometimes won’t be such a non-issue, when you make a PR from a fork on this repo. (So in the future, please don’t PR to this repo from a fork.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds CoC badge per edgi-govdata-archiving/overview#207