Handle inconsistent header case for Mementos #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also regenerates the cassette for the basic memento test, since the headers have changed.
This fixes #98, which was caused by two changes: 1. The Internet Archive now returns most *archived* header names (i.e. those prefixed with 'x-archive-org-') in lower-case. 2. In HTTP/2 (now possible since we are using HTTPS as of #97), *all* headers are lower-case/case-insensitive. This also meant I needed to make the `Memento.headers` attribute case-insensitive. I've implemented that using code largely taken from Requests, since their implementation is not public so we can't just use it directly (plus we plan to switch of Requests at some point anyway).
Mr0grog
commented
Oct 31, 2022
There was a problem hiding this comment.
Looks like docs.scipy.org is currently down, so intersphinx can’t fetch references. We should wait until it’s back before merging, but the docs build failure isn’t an issue in our code.
Side note: we definitely use the python.org references, but I’m not sure we need the scipy/numpy/pandas/matplotlib ones. We should pull them out if we don’t.
Merged
Mr0grog
deleted the
98-headers-casing-is-more-complicated-than-it-used-to-be
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #98, which was caused by two changes:
'x-archive-org-') in lower-case.Since that means it’s possible to wind up with different header name casing when running the same code on different systems, I had to go ahead and make the
Memento.headersattribute case-insensitive (we probably should have done this long ago for user friendliness anyway). I've implemented that using code largely taken from Requests, since their implementation is not public so we can't just use it directly (plus we plan to switch of Requests at some point anyway). If we wind up switching to HTTPX, they do have a public implementation we can just use instead of this.