Fix docstring for WaybackClient #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, thanks for catching this! Looks like we broke compatibility with requests sessions in #79 and did not realize it then. |
|
@dgilman can I add you to the contributors list? |
Mr0grog
approved these changes
May 30, 2023
|
I've added myself to the README in this PR |
Mr0grog
reviewed
Jul 23, 2023
| @@ -68,6 +68,7 @@ Thanks to the following people for their contributions and help on this package! | |||
| - `Will Sackfield <https://github.com/8W9aG>`_ (Code, Tests) | |||
| - `Ed Summers <https://github.com/edsu>`_ (Code, Tests) | |||
| - `Lion Szlagowski <https://github.com/LionSzl>`_ (Code, Tests) | |||
| - `David Gilman <https://pro-football-history.com>`_ (Complaints) | |||
There was a problem hiding this comment.
I’m changing this link to your GitHub profile; this is not a place to advertise other projects.
Mr0grog
pushed a commit
that referenced
this pull request
Jul 23, 2023
Update the type for the `session` parameter to WaybackClient. As of #79, it needs to be an instance of `WaybackSession`, not `requests.Session`.
|
Merged in 580adf8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client refers to some of the class members from WaybackSession (e.g.
search_calls_per_second) so this needs to be an instance of WaybackSession