Prevent installation with urllib3 v2 #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, this package is not compatible with urllib3 v2, so we need to set version constraints so package managers don’t try to install an incompatible version. Partially covers #116.
Mr0grog
added a commit
that referenced
this pull request
Sep 26, 2023
Back in #118 we “fixed” things for urllib3 v2 by marking this package as only compatible with v1, so users wouldn't wind up with bad dependency combinations. This adds real, proper support for urllib3 v2. Fixes #116. For the most part, urllib3 v2 just works, but there were two significant changes I had to make here: 1. We had a funky hack to deal with Wayback’s broken gzip handling that used the `from_httplib()` static method. That method no longer exists, and the new equivalent combines a bunch of other behavior that isn't really reasonable to override. Instead, we patch the `HTTPHeadersDict` class in v2. 2. VCR.py writes different, incompatible cassette files for v1 and v2 of urllib3 (see kevin1024/vcrpy#719). To address this in a way that doesn't make future contributions too hard, I added a custom serializer to make VCR behave compatibly between the two versions of urllib3, so you can record or read the same cassette files regardless of which version you are working with. It is no longer perfectly accurate to the response you received if using urllib3 v2, but it's generally good enough for our needs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, this package is not compatible with urllib3 v2, so we need to set version constraints so package managers don’t try to install an incompatible version.
Partially covers #116.