Improve Invitation email text #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acaporrini
force-pushed
the
fix-invitation-email
branch
5 times, most recently
from
a2b5f02
to
bbb1fa2
Compare
Mr0grog
requested changes
Feb 19, 2019
There was a problem hiding this comment.
Oh, thanks, @acaporrini! This looks great, but I think the test is going a little overboard. I wrote a little more in the inline comments.
acaporrini
force-pushed
the
fix-invitation-email
branch
from
bbb1fa2
to
977cf27
Compare
|
@Mr0grog I updated the PR |
My local test environment has an unusual HOST environment var, and the previous test didn't pick it up. This uses the helpers to make sure the URL is constructed correctly, but has to employ a few hacks to to make sure the mailer-specific config is getting picked up :\
Mr0grog
approved these changes
Feb 22, 2019
|
I made some tweaks to the text because @weatherpattern isn’t as involved any more — you couldn’t have known about that. Thanks for fixing this! |
Mr0grog
added a commit
to edgi-govdata-archiving/web-monitoring-ops
that referenced
this pull request
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #207