Recognize lowercase location header (fix #453) #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgurgel
reviewed
Jan 26, 2022
| @@ -952,7 +952,16 @@ defmodule HTTPoison.Base do | |||
| headers: process_response_headers.(headers), | |||
| request: request, | |||
| request_url: request.url, | |||
| redirect_url: :proplists.get_value("Location", headers, nil) | |||
| redirect_url: get_header(headers, "Location", nil) | |||
There was a problem hiding this comment.
I wonder if we could use :hackney_headers.get_value given that we already have hackney as a dependency?
There was a problem hiding this comment.
I had a look and gave it a try but it fails because that function (and :hackney_headers_new.get_value as well) expects the headers to be an Erlang dict while here it's a proplist (still haven't investigated why).
There was a problem hiding this comment.
Oh right! I didn't notice that! As you were then 😬
|
Thanks for the PR! It makes total sense to fix this! I've added a comment but other than that everything looks great! Thanks for adding a test case |
|
Thanks for fixing my mistake! |
|
Sorry for the long wait! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, my simple fix to issue #453 with its test case.