Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari: no result shown #27

Open
maurocicio opened this issue Nov 2, 2016 · 5 comments
Open

Safari: no result shown #27

maurocicio opened this issue Nov 2, 2016 · 5 comments

Comments

@maurocicio
Copy link

Hi there,

I have setup a bare bone demo at http://la.cicio.org/?layout=node to verify for which browser jsqrcode works (your library is named codejs/jsqrcode/qr.js).
It seems to work fine with Firefox on linux, windows, android, mac.
When using safari, though, the decoded string is not visible.
No message appears in the JS console (firebug), there are no errors, it just doesn't show the string.
Is there any other information I could supply for you to figure out what is wrong?

Thank you!

@igowerf
Copy link

igowerf commented Dec 2, 2016

@maurocicio, it looks like Safari fails on line 80 of qrcode.js. In your example, it is line 3063 of qr.js.
image.crossOrigin = "Anonymous"

I got it to work in Safari by commenting out that line and rebuilding.

@maurocicio
Copy link
Author

maurocicio commented Dec 2, 2016 via email

@edi9999
Copy link
Owner

edi9999 commented Mar 28, 2017

@igowerf do you think we should remove that line completely ?

@edi9999 edi9999 closed this as completed Mar 28, 2017
@edi9999 edi9999 reopened this Mar 28, 2017
@maurocicio
Copy link
Author

I believe it would be enough to comment it out and add a comment there, should somebody else need that line.

Mauro

@edi9999
Copy link
Owner

edi9999 commented Mar 28, 2017

I don't understand because thiw was added here :

LazarSoft/jsqrcode@20aa7ca

And it seems to be correcting a bug ...

I find this quite difficult to understand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants