Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure_edison - fix console password inputs #16

Merged
merged 1 commit into from
Mar 6, 2022
Merged

configure_edison - fix console password inputs #16

merged 1 commit into from
Mar 6, 2022

Conversation

mwallnoefer
Copy link
Collaborator

The O_NONBLOCK terminal attribute settings didn't work reliably.
But we may do without it using buffer flushing instead.

The O_NONBLOCK terminal attribute settings didn't work reliably.
But we may do without it using buffer flushing instead.
@htot
Copy link
Member

htot commented Mar 2, 2022

Before applying this patch I tried configure_edison --wifi, the issue does not occur, however password is visible while typing.
I also did configure_edison --password, and indeed the issue happens, both from serial console and ssh tty.

Do I understand correct both cases are fixed by this patch?

@mwallnoefer
Copy link
Collaborator Author

Yes, both cases are fixed by this commit.

On configure_edison --wifi I once had disabled the password input function by instead using the plain input one, but then completely forgotten to fix it properly.

@htot htot merged commit 07512df into edison-fw:master Mar 6, 2022
@htot
Copy link
Member

htot commented Mar 6, 2022

Merged, thanks!

htot pushed a commit to htot/meta-intel-edison that referenced this pull request Mar 6, 2022
htot pushed a commit to htot/meta-intel-edison that referenced this pull request Mar 7, 2022
htot pushed a commit to htot/meta-intel-edison that referenced this pull request Apr 20, 2022
htot pushed a commit to htot/meta-intel-edison that referenced this pull request Apr 20, 2022
lybtongji pushed a commit to lybtongji/meta-intel-edison that referenced this pull request Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants