Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service config doesn't work !!! #68

Closed
Farrien opened this issue Apr 29, 2021 · 16 comments
Closed

Service config doesn't work !!! #68

Farrien opened this issue Apr 29, 2021 · 16 comments
Assignees

Comments

@Farrien
Copy link

Farrien commented Apr 29, 2021

I did a lot of tests with config. And looks like it doesn't work.
It only supports default services from official list.

A year ago: I added Twitch clips support but it can no longer work.

@Farrien
Copy link
Author

Farrien commented Apr 29, 2021

I checked older editorjs version. So embed service configs works on 2.19.3 or older

@guilhae
Copy link

guilhae commented May 17, 2021

Same for me! ☝️

@kaiz16
Copy link

kaiz16 commented May 18, 2021

Same here too. Had to downgrade to older version to work.

@Farrien
Copy link
Author

Farrien commented May 18, 2021

Same here too. Had to downgrade to older version to work.

And devs do nothing)
What version do u use?

@kaiz16
Copy link

kaiz16 commented May 19, 2021

2.19.1

@jakubm95
Copy link

It doesn't work for me even with an older version of the editor.js
Even in the simplest configuration. embed: Embed,

@CiotkaCierpienia
Copy link

I've opened PR with the fix: #71, hope this will help at least with adding the plugin to editor

@dgastudio
Copy link

dgastudio commented Jul 11, 2021

2.22.1

embed: { class: Embed, config: { services: { youtube: true, vimeo: true, instagram: true, } } },
doesnt work at all

@zhiln
Copy link

zhiln commented Aug 18, 2021

Same here! Custom embed service configs work fine for me on @editorjs/editorjs version 2.19.3 or older. Upgrading the version above 2.20.0 doesn't work. Any plans on fixing this bug?

@gohabereg
Copy link
Member

Resolved in codex-team/editor.js#1781, will be published with the next release

@abelikov5
Copy link

hi @Farrien! does embed work with another services (like twitch clips) in new version?

@Farrien
Copy link
Author

Farrien commented Oct 8, 2021

hi @Farrien! does embed work with another services (like twitch clips) in new version?

Не стал пробовать новую версию после случая полгода назад. Устраивает v2.19.3 пока что

@kaiz16
Copy link

kaiz16 commented Oct 11, 2021

It seems like it's fixed in 2.22.3

@abelikov5
Copy link

in my way, just update bundle.js by adding nessesary config
image

@sabigara
Copy link

In my environment, this is fixed in @editorjs/editorjs@2.22.3

@neSpecc
Copy link
Contributor

neSpecc commented Nov 18, 2021

Resolved

@neSpecc neSpecc closed this as completed Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests