Fix: pass user configuration to Tool prepare method #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please validate this PR which solve editor-js/embed#68 |
neSpecc
reviewed
Sep 14, 2021
| @@ -279,7 +279,7 @@ export default class Tools extends Module { | |||
| }[] { | |||
| const toolPreparationList: { | |||
| function: (data: { toolName: string }) => void | Promise<void>; | |||
| data: { toolName: string }; | |||
| data: { toolName: string; config: ToolConfig }; | |||
There was a problem hiding this comment.
need to add this to the function's return type
|
@neSpecc Are you guys planning to fix this issue, or we are chilling now? |
|
It would be really appreciated if this bug could be fixed quickly, please. @gohabereg do you have time to do this ? |
neSpecc
approved these changes
Sep 16, 2021
|
resolves editor-js/embed#68 |
talyguryn
approved these changes
Sep 16, 2021
|
This fix took 5-6 months LMAO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.