Migrate Quote Tool from JavaScript to TypeScript #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neSpecc
requested changes
Jun 29, 2024
| import { IconAlignLeft, IconAlignCenter, IconQuote } from "@codexteam/icons"; | ||
| import { QuoteData, QuoteConfig, TunesMenuConfig } from "./types"; | ||
|
|
||
| export default class Quote { |
There was a problem hiding this comment.
this class should implement BlockTool
There was a problem hiding this comment.
its better to rename this file instead of removing, it will be easier to review
neSpecc
reviewed
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate Quote Tool from JavaScript to TypeScript
Fixes #65
Summary:
This pull request migrates the Quote Tool from JavaScript to TypeScript, enhancing type safety and maintainability. The migration involved converting the main
index.jsfile toindex.tsand creating atypes.tsfile for type definitions. The originalindex.jsandtypes.jsfiles have been deleted as they are no longer needed.Details:
index.jstoindex.ts, ensuring all functionalities are type-safe.types.tsto define interfaces and types used in the project.tsconfig.jsonto target ES2017 and include necessary libraries (e.g.,dom).Object.assignwith TypeScript-compatible syntax.libconfiguration.index.jsandtypes.jsas they are no longer needed.