TASK: Eliminate some codeclimate issues

editorconfig-checker · Jul 2, 2017 · a5e470a · a5e470a
1 parent 24de305
commit a5e470a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/EditorconfigChecker/Cli/Cli.php b/src/EditorconfigChecker/Cli/Cli.php
@@ -99,9 +99,9 @@ protected function getFileNames($fileGlobs, $dotfiles, $excludedPattern)
 
         if ($excludedPattern) {
             return $this->filterFiles($fileNames, $excludedPattern);
-        } else {
-            return $fileNames;
         }
+
+        return $fileNames;
     }
 
     /**
@@ -132,6 +132,8 @@ protected function filterFiles($fileNames, $excludedPattern)
      */
     protected function getExcludedPatternFromOptions($options)
     {
+        $pattern = false;
+
         if (isset($options['e']) && !isset($options['exclude'])) {
             $excludedPattern = $options['e'];
         } elseif (!isset($options['e']) && isset($options['exclude'])) {
@@ -148,8 +150,6 @@ protected function getExcludedPatternFromOptions($options)
             } else {
                 $excludedPattern = [$options['e'], $options['exclude']];
             }
-        } else {
-            return false;
         }
 
         if (is_array($excludedPattern)) {

diff --git a/src/EditorconfigChecker/Fix/TrailingWhitespaceFix.php b/src/EditorconfigChecker/Fix/TrailingWhitespaceFix.php
@@ -20,9 +20,9 @@ public static function trim($filename, $lineNumber, $eolChar)
             $lines = file($filename);
             $lines[$lineNumber] = rtrim($lines[$lineNumber]) . $eolChar;
 
-            $fp = fopen($filename, 'w');
-            fwrite($fp, implode('', $lines));
-            fclose($fp);
+            $filepointer = fopen($filename, 'w');
+            fwrite($filepointer, implode('', $lines));
+            fclose($filepointer);
 
             return true;
         }