Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.ecrc disable is unclear #143

Closed
stepancheg opened this issue Jan 21, 2021 · 3 comments · Fixed by #144
Closed

.ecrc disable is unclear #143

stepancheg opened this issue Jan 21, 2021 · 3 comments · Fixed by #144
Labels
docs issues regarding documentation good first issue help wanted

Comments

@stepancheg
Copy link
Contributor

Consider this config:

{
  "Disable": {
    "Indentation": false,
    "IndentSize": false,
  }
}

To disable the indentation checks, should the config option should be true or false? It's unclear from the readme. Can you please update the readme?

@mstruebing mstruebing added docs issues regarding documentation good first issue help wanted labels Jan 21, 2021
@mstruebing
Copy link
Member

Thank you for that issue @stepancheg
If you want, you can create a Pull Request to make the docs more clear, that would be great 🎉

@stepancheg
Copy link
Contributor Author

For now I'm struggling editorconfig-checker to use these options. No combination seems to work.

@stepancheg
Copy link
Contributor Author

OK, it is true to disable.

stepancheg added a commit to stepancheg/editorconfig-checker that referenced this issue Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs issues regarding documentation good first issue help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants