Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify line number for "Line too long" error? #154

Closed
takanuva15 opened this issue Mar 8, 2021 · 3 comments · Fixed by #155
Closed

Specify line number for "Line too long" error? #154

takanuva15 opened this issue Mar 8, 2021 · 3 comments · Fixed by #155
Labels
bug a bug which occured good first issue

Comments

@takanuva15
Copy link

takanuva15 commented Mar 8, 2021

Hi, when I run the checker on my project and one of my files has lines that are too long, it prints this error:

src/main/kotlin/de/nordgedanken/auto_hotkey/settings/ui/AhkSdkToolbarPanel.kt:
	Line too long (177 instead of 120)
	Line too long (242 instead of 120)

However, it doesn't specify which line is too long. Can we add the line number to the beginning of the Line too long output so that it's easy to trace which line is breaking the .editorconfig?

(It is showing the line number correctly if the indent size is wrong, so I imagine the same logic can be used to show the line number if the line is too long)

Sample run: https://github.com/Nordgedanken/intellij-autohotkey/runs/2052210752?check_suite_focus=true

@mstruebing
Copy link
Member

Thank you for that issue, fascinating it wasn't noticed earlier.

I will release a new version probably this week, if you use master it is already in there.

@takanuva15
Copy link
Author

Sweet thanks! I'm using the GitHub action actually; are you able to publish an update to the GitHub action?

@mstruebing
Copy link
Member

This should also be updated automatically with an official release, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a bug which occured good first issue
Projects
None yet
2 participants