Add support for disabling blocks, implements #124 #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This augments the existing "editorconfig-checker-disable-line" functionality to allow disabling checks for a block of code by adding a comment with "editorconfig-checker-disable". Checks can be re-enabled with a comment containing "editorconfig-checker-enable". Ths is very similar to how ESLint facilitates excludes: https://eslint.org/docs/user-guide/configuring#disabling-rules-with-inline-comments
|
Added |
mstruebing
approved these changes
Oct 20, 2020
|
Y'all rock. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #124, this augments the existing
editorconfig-checker-disable-linefunctionality to allow disabling checks for a block of code by adding a comment witheditorconfig-checker-disable. Checks can be re-enabled with a comment containingeditorconfig-checker-enable. This is very similar to how ESLint facilitates excludes: https://eslint.org/docs/user-guide/configuring#disabling-rules-with-inline-commentsNote that this functionality basically renders
editorconfig-checker-disable-fileredundant, because you can accomplish the same thing by addingeditorconfig-checker-disableto the top of the file. I wasn't sure ifeditorconfig-checker-disable-fileshould be preserved or not, so I didn't touch it.closes #124