fix: support empty end_of_line
in FinalNewline
#184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utils.GetEolChar(endOfLine)
returns\n
whenend_of_line
is not defined. This default contradicts the default\r\n
line ending used in windows.FinalNewline
was requiring the final newline to be this default\n
(unless otherwise defined), causing unexpected errors using windows default\r\n
line endings.This change removes the default validation against
\n
, and only validates againstend_of_line
when it is set.Fixes: #164