Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert objects to arrays #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Convert objects to arrays #10

wants to merge 3 commits into from

Conversation

ffes
Copy link
Member

@ffes ffes commented Dec 15, 2017 •
edited

Closes #2, closes #3, closes #4

This PR works towards the initial release of the editorconfig-defaults.json file.

matches and flavors are now arrays instead of objects. This makes the schema a lot less complicated and easier to validate.

@florianb and/or @deinok could you please review this PR?

@ffes ffes added the schema label Dec 15, 2017
@deinok
Copy link

deinok commented Dec 15, 2017 •
edited

Hi @ffes
Could you please order the JSON attributes of the two files or atleast in the editorconfig-defaults.schema.json and commit again?
You can use this -> http://novicelab.org/jsonabc/
It will be easier to review ;)

@ffes ffes mentioned this pull request Jun 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
schema
Projects
None yet
Milestone
No milestone
2 participants
@ffes @deinok