Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to include x64 build guides #17

Merged
merged 2 commits into from
Sep 12, 2017

Conversation

wangqr
Copy link
Contributor

@wangqr wangqr commented Sep 8, 2017

No description provided.

README.md Outdated
2. Download the [EditorConfig plugin for Notepad++][] and extract it.
3. Open `cmake-gui`, select the extracted folder as source code directory, and create a directory to build the binaries. Then click the `Configure` button. When asked for a generator, select a generator without suffix to build the x86 version, or a generator with `Win64` suffix to build the x64 version.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you wanna say the BUILD_TYPE should be set to Release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think Release should be used to compile the dll for daily use. Release builds should be smaller and runs faster than Debug builds. However using the Debug one is also fine.

  2. There are 2 places where we can change the option. The first place is when we "Configure" the CMake project, we can specify a set of available configuration types in the CMAKE_CONFIGURATION_TYPES option. The second place is when we opened the project using VS, there is a drop down menu on the toolbar so we can select the configuration from the set.

    CMAKE_CONFIGURATION_TYPES defaults to Debug;Release;MinSizeRel;RelWithDebInfo and VS defaults to the first one, which is Debug.

  3. Maybe I should call it "configuration type" instead of "build type". Do I need to change it or just remove the suggestion to use Release?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please just mention the existence of Release. Otherwise, many people may forget.
  2. Either place is OK.
  3. Sure, as long as we use some name that is consistent with what is shown in the cmake GUI/VS, it is OK.

@xuhdev xuhdev merged commit becf7a9 into editorconfig:master Sep 12, 2017
@xuhdev
Copy link
Member

xuhdev commented Sep 12, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants