Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic support for [No Name] buffers #190

Merged
merged 1 commit into from
Jan 21, 2023
Merged

Add basic support for [No Name] buffers #190

merged 1 commit into from
Jan 21, 2023

Conversation

Jorengarenar
Copy link
Contributor

@Jorengarenar Jorengarenar commented Mar 23, 2022 •
edited by cxw42

Fixes #55

@cxw42 cxw42 changed the title Add basic support for [No Name] buffers (fix #55) Add basic support for [No Name] buffers Jun 20, 2022
cxw42
cxw42 requested changes Jun 20, 2022
View reviewed changes
Copy link
Member

@cxw42 cxw42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this PR! I apologize for the delay in reviewing it. I had COVID earlier this year :( and it has really thrown off my workflow.

I have made some comments that I think will simplify the change. Would you please take a look and let me know your thoughts? Much appreciated!

plugin/editorconfig.vim Outdated Show resolved Hide resolved
plugin/editorconfig.vim Outdated Show resolved Hide resolved
plugin/editorconfig.vim Outdated Show resolved Hide resolved
plugin/editorconfig.vim Outdated Show resolved Hide resolved
@Jorengarenar Jorengarenar requested a review from cxw42 June 20, 2022 12:27
@Jorengarenar
Copy link
Contributor Author

Good to merge?

@xuhdev
Copy link
Member

xuhdev commented Sep 12, 2022

@cxw42 What do you think :)

@chris-fj
Copy link

chris-fj commented Jan 2, 2023

@cxw42 kindly reminding you this PR in case you missed it

@Jorengarenar
Copy link
Contributor Author

@cxw42 LGTM?

@cxw42
Copy link
Member

cxw42 commented Jan 21, 2023

Sorry for the delay --- I have been recovering from a concussion :( .

@cxw42
Copy link
Member

cxw42 commented Jan 21, 2023

@Jorengarenar may I force-push your branch (jorengarenar/master)? In testing this, I have found (1) it needs a rebase/squash, and (2) there are some other bugs --- including applying the current buffer's settings to :help buffers :D . I am fixing those and will update this PR if you don't mind. Otherwise, I will close this PR and open a new one.

@Jorengarenar
Copy link
Contributor Author

may I force-push your branch (jorengarenar/master)?

Of course, no problem.

Sorry for the delay --- I have been recovering from a concussion :( .

I hope you are feeling better!

cxw42
cxw42 approved these changes Jan 21, 2023
View reviewed changes
Copy link
Member

@cxw42 cxw42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased onto master, squashed, and force-pushed. Thanks again!

@cxw42 cxw42 mentioned this pull request Jan 21, 2023
Open
@cxw42
Copy link
Member

cxw42 commented Jan 21, 2023

Windows timed out (#200) --- proceeding with merge! Thanks again for the PR and for your patience!

@cxw42 cxw42 merged commit ce210ef into editorconfig:master Jan 21, 2023
@Jorengarenar
Copy link
Contributor Author

Jorengarenar commented Jan 21, 2023 •
edited

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxw42 cxw42 cxw42 approved these changes

Assignees

@Jorengarenar Jorengarenar

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

editorconfig does not apply to [No Name] buffer
4 participants
@Jorengarenar @xuhdev @chris-fj @cxw42