core: Update tests; fix bugs #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cxw42
commented
Oct 31, 2022
•
cxw42
commented
- Update core-tests submodule
- Do not look for comments in values (Remove the description of inline comments at all specification#31)
- Update property key and value limits (editorconfig/editorconfig#429 Remove section name, key and value length limits editorconfig-core-test#41)
- Fix nested-braces error (fixes Update core tests; check fnmatch for nested braces #160)
As of spec 0.15.0, `;` and `#` do not start comments when used in property values, and `\` does not escape `;` or `#`. Remove the relevant code.
Increase the minimum key and value lengths to pass the tests added in <editorconfig/editorconfig-core-test#41>.
Port the change from <editorconfig/editorconfig-core-py#33> to this core.
|
The CI failure was a timeout --- #200 |
|
Merging even given the Appveyor timeout since it looks like it would have worked if it hadn't hit the timeout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.