Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not treat directories as editable on VimEnter #217

Merged
merged 1 commit into from
Mar 17, 2023
Merged

fix: do not treat directories as editable on VimEnter #217

merged 1 commit into from
Mar 17, 2023

Conversation

kaihowl
Copy link
Contributor

@kaihowl kaihowl commented Mar 13, 2023

Fixes #212

@kaihowl kaihowl mentioned this pull request Mar 13, 2023
Merged
@pmeinhardt
Copy link
Contributor

This fixes my original issue and - unlike my previous sloppy attempt at a fix - does not break the plugin's functionality. 😅

Thanks a ton @kaihowl for catching my mistake and picking up the ball, coming up with this way of solving the problem. 🙃

xuhdev
xuhdev approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@xuhdev xuhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

@xuhdev xuhdev merged commit 0ba62c4 into editorconfig:master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuhdev xuhdev xuhdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E37, E162 when starting neovim with a directory
3 participants
@kaihowl @pmeinhardt @xuhdev