Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning scheme change: SemVer #11

Closed
xuhdev opened this issue Mar 25, 2020 · 10 comments
Closed

Versioning scheme change: SemVer #11

xuhdev opened this issue Mar 25, 2020 · 10 comments

Comments

@xuhdev
Copy link
Member

xuhdev commented Mar 25, 2020

Quoting editorconfig/editorconfig#395 (comment) :

  • When the project started, there was only one core: the C core (initial commit 2011-10-22). The specification was whatever the C core accepted.
  • The version number accepted by editorconfig -b <ver> is the specification version.
  • At present, the specification version still matches the C core version.
  • The editorconfig-core-test version lags behind the C core version because currently only the semver minor is used to indicate format changes. The C core uses the semver patch for bugfixes.

If the above is correct (@xuhdev notes: This is correct), my revised request would be that the Board:

  • officially define the version number for editorconfig -b / -v / --version purposes as the editorconfig-core-test version, so that the cores and plugins are decoupled from the specification (now that the specification is official per #361)

  • bump editorconfig-core-test to v0.13 to mark this change

  • update the core tests (or accept a PR) here to permit major.minor version numbers (no patch)

  • officially permit plugins and cores to use version numbers that are different from core-test.

  • For example, the Vimscript core might respond to -v with

      EditorConfig Vimscript core v1.0.0 - Specification Version 0.13
    

Additionally:

  • Defining the version of the specification as the version of editorconfig-core-test.

Should we make the changes proposed by the last 6 bullet points?

Please vote by commenting below: yes or no only. Voting will be closed at the end of April 9.

Discussion please goes to editorconfig/editorconfig#395

@editorconfig/board-member

cc @cxw42

@xuhdev
Copy link
Member Author

xuhdev commented Mar 25, 2020

yes

@cxw42
Copy link
Member

cxw42 commented Mar 25, 2020

@xuhdev Would you please clarify the vote request? From editorconfig/editorconfig#395 (comment) , I think this vote should also include:

Defining the version of the specification as the version of editorconfig-core-test

That is, editorconfig-core-test and the specification would have the same version numbers. Yes?

@xuhdev
Copy link
Member Author

xuhdev commented Mar 25, 2020

@cxw42 I clarified. Thanks!

@florianb
Copy link
Member

yes
with additions in editorconfig/editorconfig#395 (comment)

@sindresorhus
Copy link
Member

Yes

@johan
Copy link
Member

johan commented Mar 28, 2020 via email

@editorconfig editorconfig deleted a comment from scebotari66 Apr 7, 2020
@xuhdev
Copy link
Member Author

xuhdev commented Apr 7, 2020

Need one more vote...

@jednano
Copy link
Member

jednano commented Apr 7, 2020

yes

@xuhdev
Copy link
Member Author

xuhdev commented Apr 7, 2020

We conclude as yes

@xuhdev xuhdev closed this as completed Apr 7, 2020
@editorconfig editorconfig locked as resolved and limited conversation to collaborators Apr 7, 2020
@Mpdreamz
Copy link
Member

Late to the party but for statistic purposes: yes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants