Clarify specification #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes editorconfig#8 Fixes editorconfig#2
jednano
commented
Nov 9, 2019
xuhdev
reviewed
Nov 10, 2019
jednano
commented
Nov 10, 2019
jednano
commented
Nov 10, 2019
xuhdev
reviewed
Nov 11, 2019
|
I've again addressed all the comments as best as I could in a8a5168. |
|
I'm fine with it. 😸 |
|
🎆 |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a great time hanging out with @florianb in Berlin yesternight and we hashed out which parts of the EditorConfig specification needed clarification. This PR is the result of these conversations, combined with a couple of open issues.
Fixes #8
Fixes #2