feat(component): make radius configurable

EditVR · Jul 19, 2018 · 5b7e918 · 5b7e918
1 parent 307e78f
commit 5b7e918
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/dist/aframe-simple-link-component.js b/dist/aframe-simple-link-component.js
@@ -86,6 +86,7 @@ AFRAME.registerComponent('simple-link', {
     lookAtCamera: { default: true, type: 'boolean' },
     href: { default: '', type: 'string' },
     title: { default: '', type: 'string' },
+    radius: { default: 1, type: 'number' },
     color: { default: '#fff', type: 'color' },
     titleColor: { default: '#fff', type: 'color' },
     image: { default: '', type: 'asset' },
@@ -106,7 +107,7 @@ AFRAME.registerComponent('simple-link', {
 
     el.setAttribute('geometry', {
       primitive: 'circle',
-      radius: 1
+      radius: this.data.radius
     });
     if (this.data.image) {
       el.setAttribute('material', {

diff --git a/dist/aframe-simple-link-component.min.js b/dist/aframe-simple-link-component.min.js
diff --git a/examples/basic/index.html b/examples/basic/index.html
@@ -13,7 +13,7 @@
       <a-assets>
         <img id="linkImage" src="./assets/link.png">
       </a-assets>
-      <a-entity position="0 1 -5" simple-link="href: index.html; title: My Homepage; image: #linkImage; "></a-entity>
+      <a-entity position="0 1.5 -5" simple-link="href: index.html; title: My Homepage; image: #linkImage; radius:1.2;"></a-entity>
     </a-scene>
 
     <!-- GitHub Corner. -->

diff --git a/index.js b/index.js
@@ -14,6 +14,7 @@ AFRAME.registerComponent('simple-link', {
     lookAtCamera: { default: true, type: 'boolean' },
     href: { default: '', type: 'string' },
     title: { default: '', type: 'string' },
+    radius: { default: 1, type: 'number' },
     color: { default: '#fff', type: 'color' },
     titleColor: { default: '#fff', type: 'color' },
     image: { default: '', type: 'asset' },
@@ -34,7 +35,7 @@ AFRAME.registerComponent('simple-link', {
 
     el.setAttribute('geometry', {
       primitive: 'circle',
-      radius: 1
+      radius: this.data.radius
     });
     if (this.data.image) {
       el.setAttribute('material', {