Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add starqlte #285

Merged
merged 1 commit into from
Aug 2, 2023
Merged

add starqlte #285

merged 1 commit into from
Aug 2, 2023

Conversation

FakeShell
Copy link
Contributor

Description

Adds basic support for starqlte including description file and dtb. tested working on starqlte meaning it should also work for starqltechn but i don't have access to that variant so it remains untested

Checklist

  • Have you tested the change you are submitting?
  • Is the commits history nice and clean?

!include Platform/Qualcomm/sdm845/sdm845.dsc

[BuildOptions.common]
GCC:*_*_AARCH64_CC_FLAGS = -DENABLE_SIMPLE_INIT -DENABLE_LINUX_SIMPLE_MASS_STORAGE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • "It looks like you haven't added a mainline kernel, which means that '- ENABLE_LINUX_SIMPLE_MASS_STORAGE' doesn't need to be added."
  • I look forward to seeing its normal operation Xd
  • Please also pay attention to Ufs issues

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

star2qltechn also seems to have that option set
should that be removed as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still suggest deleting it “ -DENABLE_LINUX_SIMPLE_MASS_STORAGE”

@FakeShell
Copy link
Contributor Author

bump
anyone willing to take a look at this again?

@qaz6750 qaz6750 self-requested a review May 29, 2023 01:24
@BigfootACA
Copy link
Member

bump anyone willing to take a look at this again?

have you tested linux-simple-mass-storage?

@FakeShell
Copy link
Contributor Author

bump anyone willing to take a look at this again?

have you tested linux-simple-mass-storage?

I have not no.
i took star2qlte/chn as a template for mine and got it booting that way.

@halal-beef
Copy link
Contributor

@FakeShell If u have mass storage enabled, make sure u have a mainline dtb

// ACPI Tables

// Mainline device tree blob

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable linux-simple-mass-storage but no mainline device tree blob. you need add mainline device tree blob or disable linux-simple-mass-storage

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good now?

Copy link
Contributor

@qaz6750 qaz6750 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

!include Platform/Qualcomm/sdm845/sdm845.dsc

[BuildOptions.common]
GCC:*_*_AARCH64_CC_FLAGS = -DENABLE_SIMPLE_INIT -DENABLE_LINUX_SIMPLE_MASS_STORAGE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still suggest deleting it “ -DENABLE_LINUX_SIMPLE_MASS_STORAGE”

@BigfootACA BigfootACA merged commit 748ca4d into edk2-porting:master Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants