-
-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add starqlte #285
add starqlte #285
Conversation
Platform/Samsung/sdm845/starqlte.dsc
Outdated
!include Platform/Qualcomm/sdm845/sdm845.dsc | ||
|
||
[BuildOptions.common] | ||
GCC:*_*_AARCH64_CC_FLAGS = -DENABLE_SIMPLE_INIT -DENABLE_LINUX_SIMPLE_MASS_STORAGE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- "It looks like you haven't added a mainline kernel, which means that '- ENABLE_LINUX_SIMPLE_MASS_STORAGE' doesn't need to be added."
- I look forward to seeing its normal operation Xd
- Please also pay attention to Ufs issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
star2qltechn also seems to have that option set
should that be removed as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still suggest deleting it “ -DENABLE_LINUX_SIMPLE_MASS_STORAGE”
bump |
have you tested linux-simple-mass-storage? |
I have not no. |
@FakeShell If u have mass storage enabled, make sure u have a mainline dtb |
// ACPI Tables | ||
|
||
// Mainline device tree blob | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enable linux-simple-mass-storage but no mainline device tree blob. you need add mainline device tree blob or disable linux-simple-mass-storage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be good now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Platform/Samsung/sdm845/starqlte.dsc
Outdated
!include Platform/Qualcomm/sdm845/sdm845.dsc | ||
|
||
[BuildOptions.common] | ||
GCC:*_*_AARCH64_CC_FLAGS = -DENABLE_SIMPLE_INIT -DENABLE_LINUX_SIMPLE_MASS_STORAGE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still suggest deleting it “ -DENABLE_LINUX_SIMPLE_MASS_STORAGE”
Description
Adds basic support for starqlte including description file and dtb. tested working on starqlte meaning it should also work for starqltechn but i don't have access to that variant so it remains untested
Checklist