Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working like expected in Safari. #7

Open
perichiappan opened this issue Apr 1, 2020 · 10 comments
Open

Not working like expected in Safari. #7

perichiappan opened this issue Apr 1, 2020 · 10 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@perichiappan
Copy link

Screenshot 2020-04-01 at 3 07 06 PM
Check in safari Mac os.

@edlynvillegas
Copy link
Owner

Hello @perichiappan 😄

Thank you for providing screenshot. Sorry for this, as I'm struggling to constantly check it in iOS. But I'm trying to work on this to be able to use in apple devices.

I will write back once this is solved. Thank you again! 🤗

@edlynvillegas edlynvillegas added the good first issue Good for newcomers label Apr 6, 2020
@Mookseberg
Copy link

Hi Edlyn, first of all thanks for all the good work. Very nice app.

The NaN issue isn't only a Safari problem. It appears also with the following browser: IE. EDGE and Mozilla. On Chrome it runs smoothly.

edge
ie
mozilla
chrome

@edlynvillegas
Copy link
Owner

Hello @Mookseberg, thank you for the appreciation! 😄

I am working with this issue while fixing/adding new methods and events! Will check it also in other browsers. Thank you for the feedback and screenshots. 😄

@edlynvillegas edlynvillegas added the bug Something isn't working label Apr 11, 2020
@IngridRegina
Copy link

IngridRegina commented Apr 20, 2020

Hi @edlynvillegas and @Mookseberg ! I was dealing with the same issue on Safari and IE. Seems like they don't like the date format that was used. Here's what I did to fix it:

  1. instead of _.$cal_months_labels, I created a new array _.$cal_months = ['01', '02', '03', '04', '05', '06', '07', '08', '09', '10', '11', '12']
  2. I replaced _.$cal_months_labels with _.$cal_months everywhere inside the formatDate function
  3. Line 259, I replaced the space with /01/ (calendarHTML += _.$formatDate(new Date(monthName +' '+ new_year), _.options.titleFormat, 'en'); -> calendarHTML += _.$formatDate(new Date(monthName +'/01/ '+ new_year), _.options.titleFormat, 'en');)

I might have missed something since I have changed the code quite a lot, but I hope this helps :)

Edit: I also opened a pull request with these fixes.

@Mookseberg
Copy link

Hi IngridRegina and edlynvillegas ,

Have a look. Although I altered the CSS a lot, it is still the EvoCalendar. I made a workaround with the changes of IngridRegina and it works on Firefox, Chrome, IE and Edge. I will check my iOS device later on and will revert on that. Thanks for now.

Knipsel

and have a look on the index page: https://radioclublimburg.nl/

tnx for all the good work

@IngridRegina
Copy link

Hey @Mookseberg , glad I could help :) Also maybe you did it like this on purpose, but if you want the months on the left sidebar to still show as full month names instead of numbers, you can use the _.$cal_months_labels array only in the buildSidebarHTML function.

@gayatri-a-b
Copy link

@IngridRegina Which file do you make fix _.$cal_months_labels? Currently my site doesn't work on Safari but no clue how to fix it (https://gayatri-a-b.github.io/)

@saber-mogaddas
Copy link

saber-mogaddas commented Mar 16, 2021

hi, thanks for all the good work edlyin.
I fixed problem in safari :
change title in EvoCalendar.prototype.buildCalendar :
title = _.formatDate(new Date((_.$active.month + 1) + '/01/' + _.$active.year), _.options.titleFormat, _.options.language);

edit : fixed all bug about cross browser in this repository : https://github.com/saber-mogaddas/evo-calendar

@parulpat
Copy link

hi
i am using evo calander but eventheader and event body is not displyed on mozial you can i shared screen shot
IN CROME BROWSER
Screenshot 2021-06-27 142138
and in MOZILA FIRE FOX
Screenshot 2021-06-27 142731
please help me what can i do for this issuse

@Realmaker
Copy link

When the dates are not shown on iOS devices is a matter of the date format.

In the demo there ist used F/d/Y (February/15/1999) - which is NOT WORKING FOR IOS.

Use M d Y (Feb 15 1999) instead. It works everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

8 participants