Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design Doc Review (Sample State + Backend/Frontend Routes) #2

Closed
3 tasks done
rlim92 opened this issue Nov 13, 2020 · 1 comment
Closed
3 tasks done

Design Doc Review (Sample State + Backend/Frontend Routes) #2

rlim92 opened this issue Nov 13, 2020 · 1 comment

Comments

@rlim92
Copy link

rlim92 commented Nov 13, 2020 •
edited by edmondthui
Loading

Hey Edmond! Design docs looking good so far, some suggestions below:

Sample State:

  • are slices individual pieces of a pie? Can a user have multiple pies? If so need a reference to what pie_id

Backend Routes:

  • how much data will grabbing the portfolios grab?

Frontend Routes:

  • Looks good here!

Great work on these.
@edmondthui
Copy link
Owner

  • changed slices to pies for clarity
  • talked over backend & frontend routes in meeting
  • portfolios has_many pies and will grab all pies when clicked
  • pies has_many stocks through holdings and will grab all stocks when clicked
  • showed Rich M1Finance features

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rlim92 @edmondthui