Change __DIR__ to dirname(__FILE__) in order to works with PHP 5.2.4...
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2.4+ The magic constant `__DIR__` was added in PHP 5.3.0, as said here: http://php.net/manual/en/language.constants.predefined.php
|
@edmundask do you think it's useful, or you prefer to update the requirements of this spark to PHP 5.3+? I say that because in INSTALLATION & REQUIREMENTS at the DOCS it's PHP 5.2.4+. In my opinion the best choice should be maintain the 5.2.4+, because either CodeIgniter and Twig support that, ok? |
|
Sorry, I didn't have time to reply. Yes, this seems to make sense. I actually wasn't aware of the fact that |
edmundask
added a commit
that referenced
this pull request
May 4, 2012
Change __DIR__ to dirname(__FILE__) to avoid compatibility issues with PHP 5.2.4 and older versions.
|
Thanks, man! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...+
The magic constant
__DIR__was added in PHP 5.3.0, as said here: http://php.net/manual/en/language.constants.predefined.php