Narrow the type prop returned from the getCollectionProps helper
#562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reference URL in the getCollectionProps helper function documentation was outdated and incorrect. This commit updates the URL in the documentation comments to correctly point to the getCollectionProps section of the conform guide, enhancing code readability and understanding.
Update the type definitions for the `getCollectionProps` helper to fix widening issues with the `type` prop that is returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the type definitions for the
getCollectionPropshelper function to better narrow thetypeprop that is returned. This resolves #561.I also corrected the URL to the docs in the
getCollectionPropshelper function's JSDoc comment.