feature: adding subdomain center as source #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove sonar as sub source + (linting) remove depguard
Update README.md
edoardottt
requested changes
Oct 17, 2023
pkg/opendb/subdomaincenter.go
Outdated
| // SubdomainCenter retrieves from the url below some known subdomains. | ||
| func SubdomainCenter(domain string, plain bool) []string { | ||
| if !plain { | ||
| fmt.Println("Pulling data from ThreatCrowd") |
pkg/opendb/subdomaincenter.go
Outdated
| defer resp.Body.Close() | ||
|
|
||
| dec := json.NewDecoder(resp.Body) | ||
| err = dec.Decode(&wrapper) |
There was a problem hiding this comment.
Here trying this code I get the err json: cannot unmarshal array into Go value of type struct { Records []string "json:\"subdomains\"" }
|
@edoardottt , Please look into 5217aa6 |
edoardottt
requested changes
Oct 18, 2023
pkg/opendb/subdomaincenter.go
Outdated
| // SubdomainCenter retrieves from the url below some known subdomains. | ||
| func SubdomainCenter(domain string, plain bool) []string { | ||
| if !plain { | ||
| fmt.Println("Pulling data from Subdomain") |
There was a problem hiding this comment.
Should be Pulling data from Subdomain Center
|
Please review - #df98dcc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This source returns the empty list for almost all the domains. The original sourcecode has rate limiting (upto 2 request) as well.