Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruff for linting and error checking #50

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Use ruff for linting and error checking #50

merged 1 commit into from
Sep 27, 2023

Conversation

WhyNotHugo
Copy link
Contributor

Ruff integrating flake8, many of its plugins and isort all into a single program. It's substantially faster, can auto-fix some types of errors, and allows enabling additional checks in future.

Needs: #48

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Merging #50 (a00f1f7) into main (0421d7e) will not change coverage.
Report is 11 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #50   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          328       328           
=========================================
  Hits           328       328           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@WhyNotHugo WhyNotHugo marked this pull request as ready for review September 26, 2023 17:24
Ruff integrating flake8, many of its plugins and isort all into a single
program. It's substantially faster, can auto-fix some types of errors,
and allows enabling additional checks in future.

Needs: #48
@WhyNotHugo WhyNotHugo mentioned this pull request Sep 27, 2023
Copy link
Collaborator

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 👍
In the long term, I guess we can also enable more of these checks, but it is a good place to start!

@timobrembeck timobrembeck merged commit 72705c6 into sphinx-doc:main Sep 27, 2023
30 checks passed
@WhyNotHugo WhyNotHugo deleted the ruff branch September 27, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants